hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9076) Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten()
Date Tue, 22 Sep 2015 12:41:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902516#comment-14902516
] 

Vinayakumar B commented on HDFS-9076:
-------------------------------------

Thanks [~surendrasingh]
Some nits/suggestions.

1. IMO, you can change {{getSource()}} to {{getSrc()}} :) Just to be consistent with name.

2. Remove 'public' access modifier.

3. You can still include fileId along with 'src' in log message. It will be helpful IMO.

> Log full path instead of inodeId in DFSClient#closeAllFilesBeingWritten()
> -------------------------------------------------------------------------
>
>                 Key: HDFS-9076
>                 URL: https://issues.apache.org/jira/browse/HDFS-9076
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-9076.patch
>
>
> {code}
>        try {
>           if (abort) {
>             out.abort();
>           } else {
>             out.close();
>           }
>         } catch(IOException ie) {
>           LOG.error("Failed to " + (abort? "abort": "close") +
>                   " inode " + inodeId, ie);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message