hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9065) Include commas on # of files, blocks, total filesystem objects in NN Web UI
Date Mon, 14 Sep 2015 22:20:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744392#comment-14744392
] 

Haohui Mai commented on HDFS-9065:
----------------------------------

Looks good to me. One nit:

{code}
+        data['fs']['ObjectsTotal'] =
+            data['fs']['FilesTotal'] + data['fs']['BlocksTotal'];
{code}

Can it be

{code}
        data.fs.ObjectsTotal = +data.fs.FilesTotal + data.fs.BlocksTotal;
{code}

?

+1 after addressed.

> Include commas on # of files, blocks, total filesystem objects in NN Web UI
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-9065
>                 URL: https://issues.apache.org/jira/browse/HDFS-9065
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: HDFS
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Minor
>         Attachments: HDFS-9065.001.patch, HDFS-9065.002.patch, HDFS-9065.003.patch
>
>
> Include commas on the number of files, blocks, and total filesystem objects in the NN
Web UI (please see example below) to make the numbers easier to read.
> Current format:
> 3236 files and directories, 1409 blocks = 4645 total filesystem object(s).
> Proposed format:
> 3,236 files and directories, 1,409 blocks = 4,645 total filesystem object(s).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message