hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9039) Separate client and server side methods of o.a.h.hdfs.NameNodeProxies
Date Wed, 23 Sep 2015 04:11:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903921#comment-14903921
] 

Hudson commented on HDFS-9039:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8501 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8501/])
HDFS-9039. Separate client and server side methods of o.a.h.hdfs.NameNodeProxies. Contributed
by Mingliang Liu. (wheat9: rev 63d9f1596c92206cce3b72e3214d2fb5f6242b90)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolPB.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/WrappedFailoverProxyProvider.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ConfiguredFailoverProxyProvider.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/WrappedFailoverProxyProvider.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/AbstractNNFailoverProxyProvider.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolPB.java


> Separate client and server side methods of o.a.h.hdfs.NameNodeProxies
> ---------------------------------------------------------------------
>
>                 Key: HDFS-9039
>                 URL: https://issues.apache.org/jira/browse/HDFS-9039
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9039.000.patch, HDFS-9039.001.patch, HDFS-9039.002.patch
>
>
> Currently the {{org.apache.hadoop.hdfs.NameNodeProxies}} class is used by both {{org.apache.hadoop.hdfs.server}}
package (for server side protocols) and {{DFSClient}} class (for {{ClientProtocol}}). The
{{DFSClient}} class should be moved to {{hadoop-hdfs-client}} module (see [HDFS-8053 | https://issues.apache.org/jira/browse/HDFS-8053]).
As the {{org.apache.hadoop.hdfs.NameNodeProxies}} class also depends on server side protocols
(e.g. {{JournalProtocol}} and {{NamenodeProtocol}}), we can't simply move this class to the
{{hadoo-hdfs-client}} module as well.
> This jira tracks the effort of moving {{ClientProtocol}} related static methods in {{org.apache.hadoop.hdfs.NameNodeProxies}}
class to {{hadoo-hdfs-client}} module. A good place to put these static methods is a new class
named {{NameNodeProxiesClient}}.
> The checkstyle warnings can be addressed in [HDFS-8979], and removing the _slf4j_ logger
guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be addressed in [HDFS-8971].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message