hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9039) Split o.a.h.hdfs.NameNodeProxies class into two classes in hadoop-hdfs-client and hadoop-hdfs modules respectively
Date Wed, 23 Sep 2015 02:52:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903858#comment-14903858
] 

Hadoop QA commented on HDFS-9039:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m 56s | Findbugs (version 3.0.0) appears to be broken
on trunk. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 59s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m  9s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   2m  7s | The applied patch generated  11 new checkstyle
issues (total was 0, now 11). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   4m 31s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 19s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 193m 29s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 31s | Tests passed in hadoop-hdfs-client. |
| | | 242m 43s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestBlockManager |
|   | hadoop.hdfs.server.blockmanagement.TestNodeCount |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12761752/HDFS-9039.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cc2b473 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/12610/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12610/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12610/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12610/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12610/console |


This message was automatically generated.

> Split o.a.h.hdfs.NameNodeProxies class into two classes in hadoop-hdfs-client and hadoop-hdfs
modules respectively
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-9039
>                 URL: https://issues.apache.org/jira/browse/HDFS-9039
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9039.000.patch, HDFS-9039.001.patch, HDFS-9039.002.patch
>
>
> Currently the {{org.apache.hadoop.hdfs.NameNodeProxies}} class is used by both {{org.apache.hadoop.hdfs.server}}
package (for server side protocols) and {{DFSClient}} class (for {{ClientProtocol}}). The
{{DFSClient}} class should be moved to {{hadoop-hdfs-client}} module (see [HDFS-8053 | https://issues.apache.org/jira/browse/HDFS-8053]).
As the {{org.apache.hadoop.hdfs.NameNodeProxies}} class also depends on server side protocols
(e.g. {{JournalProtocol}} and {{NamenodeProtocol}}), we can't simply move this class to the
{{hadoo-hdfs-client}} module as well.
> This jira tracks the effort of moving {{ClientProtocol}} related static methods in {{org.apache.hadoop.hdfs.NameNodeProxies}}
class to {{hadoo-hdfs-client}} module. A good place to put these static methods is a new class
named {{NameNodeProxiesClient}}.
> The checkstyle warnings can be addressed in [HDFS-8979], and removing the _slf4j_ logger
guards when calling {{LOG.debug()}} and {{LOG.trace()}} can be addressed in [HDFS-8971].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message