hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9037) Trash messages should be handled by Logger instead of being delivered on System.out
Date Thu, 10 Sep 2015 05:16:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738182#comment-14738182
] 

Akira AJISAKA commented on HDFS-9037:
-------------------------------------

Thanks [~ashutoshc] and [~wheat9] for the comments.
bq. Why this is an incompatible change?
??Changing the path of a command, removing or renaming command line options, the order of
arguments, or the command return code and output break compatibility and may adversely affect
users.?? (http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI)
I'm thinking this message may be treated as 'output' (not log) since it is delivered on System.out.

> Trash messages should be handled by Logger instead of being delivered on System.out 
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-9037
>                 URL: https://issues.apache.org/jira/browse/HDFS-9037
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: logging
>    Affects Versions: 2.6.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9037.000.patch
>
>
> Specifically,
> {code}
>   if (success) {
>       System.out.println("Moved: '" + p + "' to trash at: " +
>           trash.getCurrentTrashDir() );
>     }
> {code}
> should be:
> {code}
>   if (success) {
>       LOG.info("Moved: '" + p + "' to trash at: " + trash.getCurrentTrashDir());
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message