hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client
Date Sat, 12 Sep 2015 18:04:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742171#comment-14742171
] 

Haohui Mai commented on HDFS-9022:
----------------------------------

Thanks for the work. The patch looks good. I think it makes sense to rename {{getAddress()}}
and {{getUri()}} to {{getNNAddress()}} and {{getNNUri()}} respectively.


> Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client
> ----------------------------------------------------------------------
>
>                 Key: HDFS-9022
>                 URL: https://issues.apache.org/jira/browse/HDFS-9022
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-9022.000.patch, HDFS-9022.001.patch
>
>
> The static helper methods in NameNodes are used in {{hdfs-client}} module. For example,
it's used by the {{DFSClient}} and {{NameNodeProxies}} classes which are being moved to {{hadoop-hdfs-client}}
module. Meanwhile, we should keep the {{NameNode}} class itself in the {{hadoop-hdfs}} module.
> This jira tracks the effort of moving the following static helper methods out of  {{NameNode}}
and thus {{hadoop-hdfs}} module. A good place to put these methods is the {{DFSUtilClient}}
class:
> {code}
> public static InetSocketAddress getAddress(String address);
> public static InetSocketAddress getAddress(Configuration conf);
> public static InetSocketAddress getAddress(URI filesystemURI);
> public static URI getUri(InetSocketAddress namenode);
> {code}
> Be cautious not to bring new checkstyle warnings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message