hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-9008) Balancer#Parameters class could use a builder pattern
Date Sat, 12 Sep 2015 09:52:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741998#comment-14741998
] 

Tsz Wo Nicholas Sze commented on HDFS-9008:
-------------------------------------------

Just took a quick look at the patch.  Everything seems fine.  Please feel free to commit it.

> Balancer#Parameters class could use a builder pattern
> -----------------------------------------------------
>
>                 Key: HDFS-9008
>                 URL: https://issues.apache.org/jira/browse/HDFS-9008
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: balancer & mover
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>            Priority: Minor
>         Attachments: HDFS-9008-trunk-v1.patch, HDFS-9008-trunk-v2.patch, HDFS-9008-trunk-v3.patch,
HDFS-9008-trunk-v4.patch, HDFS-9008-trunk-v5.patch
>
>
> The Balancer#Parameters class is violating a few checkstyle rules.
> # Instance variables are not privately scoped and do not have accessor methods.
> # The Balancer#Parameter constructor has too many arguments (according to checkstyle).
> Changing this class to use the builder pattern could fix both of these style issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message