hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8953) DataNode Metrics logging
Date Wed, 09 Sep 2015 09:20:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736528#comment-14736528
] 

Vinayakumar B commented on HDFS-8953:
-------------------------------------

Thanks [~kanaka] for the effort.

Here are some comments on the patch.

1. {{datanode.metrics.logger=INFO,NullAppender}}, I think default we can set to enable metrics
logs as done for nnmetrics. I feel both should be in sync in defualt behaviour. If NullAppender
is used, same is preferred for nnmetrics too.

2. I see no trim() happens for dn-metrics but done for NN. Any particular reason for this?

3. {{public ScheduledThreadPoolExecutor getMetricsLoggerTimer()}},  I think default accessor
is enough. No need of public. agree?

> DataNode Metrics logging
> ------------------------
>
>                 Key: HDFS-8953
>                 URL: https://issues.apache.org/jira/browse/HDFS-8953
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Kanaka Kumar Avvaru
>            Assignee: Kanaka Kumar Avvaru
>         Attachments: HDFS-8953-01.patch, HDFS-8953-02.patch
>
>
> HDFS-8880 added metrics logging at NameNode. Similarly, this JIRA is to  add a separate
logger for metrics at DN



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message