hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8632) Erasure Coding: Add InterfaceAudience annotation to the erasure coding classes
Date Mon, 21 Sep 2015 18:37:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901153#comment-14901153
] 

Zhe Zhang commented on HDFS-8632:
---------------------------------

Thanks Rakesh for the work! Most annotations in the patch look good. The following are worth
more discussions. [~andrew.wang] Could you share some advice in the context of release management?

{code}
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
 public final class ErasureCodingPolicy
{code}
{{Evolving}} actually sounds right to me. A side note is that we should probably have something
similar to {{BlockStoragePolicySpi}} that is {{Stable}}.

{code}
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
 public class DFSStripedInputStream extends DFSInputStream {
{code}
{{DFSInputStream}} itself is {{Unstable}} (the default for {{Private}}). I guess we should
make them consistent. Similar for {{StripedDataStreamer}} and {{BlockInfoStriped}}.

{code}
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
 public class BlockPlacementPolicies{
{code}
Similar as above, should this be {{Evolving}} or the default {{Unstable}}?

> Erasure Coding: Add InterfaceAudience annotation to the erasure coding classes
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-8632
>                 URL: https://issues.apache.org/jira/browse/HDFS-8632
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8632-HDFS-7285-00.patch, HDFS-8632-HDFS-7285-01.patch, HDFS-8632-HDFS-7285-02.patch,
HDFS-8632-HDFS-7285-03.patch
>
>
> I've noticed some of the erasure coding classes missing {{@InterfaceAudience}} annotation.
It would be good to identify the classes and add proper annotation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message