hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8550) Erasure Coding: Fix FindBugs Multithreaded correctness Warning
Date Fri, 18 Sep 2015 11:41:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14847288#comment-14847288
] 

Hadoop QA commented on HDFS-8550:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  18m 48s | Findbugs (version ) appears to be broken on
HDFS-7285. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |  10m  7s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  12m 51s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 18s | The applied patch generated 1 release
audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 40s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   2m  1s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 40s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   2m 56s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 47s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 239m 34s | Tests failed in hadoop-hdfs. |
| | | 291m 46s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.blockmanagement.TestBlockManager |
|   | hadoop.hdfs.TestWriteStripedFileWithFailure |
|   | hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots |
|   | hadoop.hdfs.TestReplaceDatanodeOnFailure |
|   | hadoop.hdfs.TestAppendSnapshotTruncate |
|   | hadoop.hdfs.TestRollingUpgrade |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12757221/HDFS-8550-HDFS-7285-02.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / 607bda2 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/12537/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12537/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12537/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12537/console |


This message was automatically generated.

> Erasure Coding: Fix FindBugs Multithreaded correctness Warning
> --------------------------------------------------------------
>
>                 Key: HDFS-8550
>                 URL: https://issues.apache.org/jira/browse/HDFS-8550
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8550-HDFS-7285-00.patch, HDFS-8550-HDFS-7285-01.patch, HDFS-8550-HDFS-7285-02.patch
>
>
> Please find the findbug warnings [report|https://builds.apache.org/job/PreCommit-HDFS-Build/12444/artifact/patchprocess/patchFindbugsWarningshadoop-hdfs.html]
> 1) {code}
> Bug type IS2_INCONSISTENT_SYNC (click for details) 
> In class org.apache.hadoop.hdfs.DFSStripedInputStream
> Field org.apache.hadoop.hdfs.DFSStripedInputStream.curStripeBuf
> Synchronized 90% of the time
> Unsynchronized access at DFSStripedInputStream.java:[line 829]
> Synchronized access at DFSStripedInputStream.java:[line 183]
> Synchronized access at DFSStripedInputStream.java:[line 186]
> Synchronized access at DFSStripedInputStream.java:[line 184]
> Synchronized access at DFSStripedInputStream.java:[line 382]
> Synchronized access at DFSStripedInputStream.java:[line 460]
> Synchronized access at DFSStripedInputStream.java:[line 461]
> Synchronized access at DFSStripedInputStream.java:[line 461]
> Synchronized access at DFSStripedInputStream.java:[line 285]
> Synchronized access at DFSStripedInputStream.java:[line 297]
> Synchronized access at DFSStripedInputStream.java:[line 298]
> {code}
> 2) 
> {code}
> Unread field: org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
> Bug type URF_UNREAD_FIELD (click for details) 
> In class org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo
> Field org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
> At DFSStripedInputStream.java:[line 126]
> {code}
> 3) 
> {code}
> Unchecked/unconfirmed cast from org.apache.hadoop.hdfs.protocol.LocatedBlock to org.apache.hadoop.hdfs.protocol.LocatedStripedBlock
in org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock,
BlockTokenIdentifier$AccessMode)
> Bug type BC_UNCONFIRMED_CAST (click for details) 
> In class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager
> In method org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock,
BlockTokenIdentifier$AccessMode)
> Actual type org.apache.hadoop.hdfs.protocol.LocatedBlock
> Expected org.apache.hadoop.hdfs.protocol.LocatedStripedBlock
> Value loaded from b
> At BlockManager.java:[line 974]
> {code}
> 4) 
> {code}
> Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy,
int, LocatedStripedBlock, long, long, ByteBuffer)
> Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) 
> In class org.apache.hadoop.hdfs.util.StripedBlockUtil
> In method org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy,
int, LocatedStripedBlock, long, long, ByteBuffer)
> At StripedBlockUtil.java:[line 375]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message