hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8189) ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent
Date Wed, 30 Sep 2015 19:39:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938720#comment-14938720
] 

Hudson commented on HDFS-8189:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #465 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/465/])
HDFS-8189. ClientProtocol#createErasureCodingZone API was wrongly (zhezhang: rev 5eb17e57265655b9c704e7fe664a29071f7902ae)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES-HDFS-EC-7285.txt


> ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-8189
>                 URL: https://issues.apache.org/jira/browse/HDFS-8189
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Uma Maheswara Rao G
>            Assignee: Vinayakumar B
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-8189-01.patch
>
>
> Currently createErasureCodingZone was annotated as Idempotent
> But it should be annotated as @AtMostOnce as we handle retries via retryCache.
> {code}
>  @Idempotent
>   public void createErasureCodingZone(String src, ECSchema schema)
>       throws IOException;
> {code}
> It will fail to create Zone if its already a zone. So, simply we can not retry by ignoring
previous call success. So, we were using retryCache already for handling this situation.
> {code}
>  if (getECSchema(srcIIP) != null) {
>       throw new IOException("Directory " + src + " is already in an " +
>           "erasure coding zone.");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message