hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8053) Move DFSIn/OutputStream and related classes to hadoop-hdfs-client
Date Sat, 26 Sep 2015 06:12:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909119#comment-14909119
] 

Haohui Mai commented on HDFS-8053:
----------------------------------

Thanks for updating the patch! The change looks mostly good to me.

{code}
+public class SecureResources {
+  private final ServerSocket streamingSocket;
+  private final ServerSocketChannel httpServerSocket;
+  public SecureResources(ServerSocket streamingSocket, ServerSocketChannel httpServerSocket)
{
+    this.streamingSocket = streamingSocket;
+    this.httpServerSocket = httpServerSocket;
+  }
...
{code}

{{SecureResources}} used only by DataNodes. It should not be exposed to the hdfs-client package.
I don't think there is any needs to change it  or the {{TcpPeerServer}}.

> Move DFSIn/OutputStream and related classes to hadoop-hdfs-client
> -----------------------------------------------------------------
>
>                 Key: HDFS-8053
>                 URL: https://issues.apache.org/jira/browse/HDFS-8053
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Haohui Mai
>            Assignee: Mingliang Liu
>         Attachments: HDFS-8053.000.patch, HDFS-8053.001.patch, HDFS-8053.002.patch, HDFS-8053.003.patch,
HDFS-8053.004.patch
>
>
> This jira tracks the effort of moving the {{DFSInputStream}} and {{DFSOutputSream}} classes
from {{hadoop-hdfs}} to {{hadoop-hdfs-client}} module.
> Guidelines:
> * As the {{DFSClient}} is heavily coupled to these two classes, we should move it together.
> * Related classes should be addressed in separate jiras if they're independent and complex
enough.
> * The checkstyle warnings can be addressed in [HDFS-8979 | https://issues.apache.org/jira/browse/HDFS-8979]
> * Removing the _slf4j_ logger guards when calling {{LOG.debug()}} and {{LOG.trace()}}
can be addressed in [HDFS-8971 | https://issues.apache.org/jira/browse/HDFS-8971].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message