Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CACF817F8C for ; Fri, 28 Aug 2015 00:49:46 +0000 (UTC) Received: (qmail 54472 invoked by uid 500); 28 Aug 2015 00:49:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 54373 invoked by uid 500); 28 Aug 2015 00:49:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 54170 invoked by uid 99); 28 Aug 2015 00:49:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Aug 2015 00:49:46 +0000 Date: Fri, 28 Aug 2015 00:49:46 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8938) Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717840#comment-14717840 ] Hudson commented on HDFS-8938: ------------------------------ FAILURE: Integrated in Hadoop-Yarn-trunk #1047 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1047/]) HDFS-8938. Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager. Contributed by Mingliang Liu. (wheat9: rev 4e9307f26dd41270f95fb50166e1a091852e4d58) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockToMarkCorrupt.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/ReplicationWork.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Revert "HDFS-8938. Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager. Contributed by Mingliang Liu." (wheat9: rev 035ed26147f10620fc6ed3a514d9ebbcc31304b5) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockToMarkCorrupt.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/ReplicationWork.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager > -------------------------------------------------------------------------------------- > > Key: HDFS-8938 > URL: https://issues.apache.org/jira/browse/HDFS-8938 > Project: Hadoop HDFS > Issue Type: Task > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HDFS-8938.000.patch, HDFS-8938.001.patch, HDFS-8938.002.patch, HDFS-8938.003.patch, HDFS-8938.004.patch, HDFS-8938.005.patch, HDFS-8938.006.patch, HDFS-8938.007.patch > > > This jira proposes to refactor two inner static classes, {{BlockToMarkCorrupt}} and {{ReplicationWork}} from {{BlockManager}} to standalone classes. The refactor also improves readability by abstracting the complexity of scheduling and validating replications to corresponding helper methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)