Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B262118761 for ; Fri, 7 Aug 2015 10:18:46 +0000 (UTC) Received: (qmail 24627 invoked by uid 500); 7 Aug 2015 10:18:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24576 invoked by uid 500); 7 Aug 2015 10:18:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24558 invoked by uid 99); 7 Aug 2015 10:18:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Aug 2015 10:18:46 +0000 Date: Fri, 7 Aug 2015 10:18:46 +0000 (UTC) From: "Rakesh R (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8854) Erasure coding: add ECPolicy to replace schema+cellSize in hadoop-hdfs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661600#comment-14661600 ] Rakesh R commented on HDFS-8854: -------------------------------- Nice Work [~walter.k.su]! I've referred {{HDFS-8854-HDFS-7285.02.patch}} and have few comments, please see: # Since ErasureCodingPolicy has {{cellSize}}, can we avoid separate variable {{cellSize}} in DFSStripedInputStream.java, DFSStripedOutputStream.java classes. # typo: {{ecPoilcy}}, {{ecPoilcies}}. Please correct this to {{ecPolicy}}, {{ecPolicies}} # one general suggestion - while commenting or logging or #toString() instead of {{EC polices}}, good to use {{erasure coding policies}} explicitly. I remember sometime back there were few discussions to use this way > Erasure coding: add ECPolicy to replace schema+cellSize in hadoop-hdfs > ---------------------------------------------------------------------- > > Key: HDFS-8854 > URL: https://issues.apache.org/jira/browse/HDFS-8854 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: HDFS-7285 > Reporter: Walter Su > Assignee: Walter Su > Attachments: HDFS-8854-Consolidated-20150806.02.txt, HDFS-8854-HDFS-7285.00.patch, HDFS-8854-HDFS-7285.01.patch, HDFS-8854-HDFS-7285.02.patch, HDFS-8854.00.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)