Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61C9B17C1D for ; Thu, 20 Aug 2015 09:40:35 +0000 (UTC) Received: (qmail 60657 invoked by uid 500); 20 Aug 2015 09:31:46 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 60609 invoked by uid 500); 20 Aug 2015 09:31:46 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 60593 invoked by uid 99); 20 Aug 2015 09:31:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 09:31:46 +0000 Date: Thu, 20 Aug 2015 09:31:46 +0000 (UTC) From: "J.Andreina (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8853) Erasure Coding: Provide ECSchema validation when creating ECZone MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704587#comment-14704587 ] J.Andreina commented on HDFS-8853: ---------------------------------- Thanks [~zhz] . Sorry for the delay in updating the patch. Please review. bq. In the long term, it might be better for the client to pass a String to NN instead of the actual policy/schema. Here do you mean , to pass only the policy name which creating the zone.? > Erasure Coding: Provide ECSchema validation when creating ECZone > ---------------------------------------------------------------- > > Key: HDFS-8853 > URL: https://issues.apache.org/jira/browse/HDFS-8853 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: J.Andreina > Attachments: HDFS-8853-HDFS-7285-01.patch, HDFS-8853-HDFS-7285-merge-02.patch > > > Presently the {{DFS#createErasureCodingZone(path, ecSchema, cellSize)}} doesn't have any validation that the given {{ecSchema}} is available in {{ErasureCodingSchemaManager#activeSchemas}} list. Now, if it doesn't exists then will create the ECZone with {{null}} schema. IMHO we could improve this by doing necessary basic sanity checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)