hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-8971) Remove guards when calling LOG.debug() and LOG.trace() in shortcircuit package
Date Thu, 27 Aug 2015 05:50:45 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mingliang Liu updated HDFS-8971:
--------------------------------
    Target Version/s: 2.8.0
       Fix Version/s:     (was: 2.8.0)

> Remove guards when calling LOG.debug() and LOG.trace() in shortcircuit package
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-8971
>                 URL: https://issues.apache.org/jira/browse/HDFS-8971
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>
> We moved the {{shortcircuit}} package from {{hadoop-hdfs}} to {{hadoop-hdfs-client}}
module in JIRA [HDFS-8934|https://issues.apache.org/jira/browse/HDFS-8934] and [HDFS-8951|https://issues.apache.org/jira/browse/HDFS-8951].
Meanwhile, we also replaced the _log4j_ log with _slf4j_ logger. There were existing code
in the {{shortcircuit}} package to guard the log when calling {{LOG.debug()}} and {{LOG.trace()}},
e.g. in {{ShortCircuitCache.java}}, we have code like this:
> {code}
> 724    if (LOG.isTraceEnabled()) {
> 725      LOG.trace(this + ": found waitable for " + key);
> 726    }
> {code}
> In _slf4j_, this kind of guard is not necessary. We should clean the code by removing
the guard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message