hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8934) Move ShortCircuitShm to hdfs-client
Date Fri, 21 Aug 2015 22:14:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707549#comment-14707549
] 

Haohui Mai commented on HDFS-8934:
----------------------------------

Thanks for the work, Mingliang! It looks good to me overall.

Some quick comments:

1. You can generate the patch using {{git diff -M}}.
2. The new patch should not introduce new trailing whitespace.

+1 after a clean Jenkins run and addressed the above comments.

Since this jira is mostly about moving the relevant classes to the {{hdfs-client}} package,
it might be better to address the following comments might be  addressed in separated jiras:

1. No guards are required when calling {{LOG.debug()}} and {{LOG.trace()}} in slf4j.
2. Fixing the checkstyle error.

> Move ShortCircuitShm to hdfs-client
> -----------------------------------
>
>                 Key: HDFS-8934
>                 URL: https://issues.apache.org/jira/browse/HDFS-8934
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HDFS-8934.000.patch
>
>
> This jira tracks the effort of moving the {{ShortCircuitShm}} class into the hdfs-client
module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message