hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8854) Erasure coding: add ECPolicy to replace schema+cellSize in hadoop-hdfs
Date Fri, 07 Aug 2015 10:18:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661600#comment-14661600

Rakesh R commented on HDFS-8854:

Nice Work [~walter.k.su]!

I've referred {{HDFS-8854-HDFS-7285.02.patch}} and have few comments, please see:
# Since ErasureCodingPolicy has {{cellSize}}, can we avoid separate variable {{cellSize}}
in DFSStripedInputStream.java, DFSStripedOutputStream.java classes.
# typo: {{ecPoilcy}}, {{ecPoilcies}}. Please correct this to {{ecPolicy}}, {{ecPolicies}}
# one general suggestion - while commenting or logging or #toString() instead of {{EC polices}},
good to use {{erasure coding policies}} explicitly. I remember sometime back there were few
discussions to use this way

> Erasure coding: add ECPolicy to replace schema+cellSize in hadoop-hdfs
> ----------------------------------------------------------------------
>                 Key: HDFS-8854
>                 URL: https://issues.apache.org/jira/browse/HDFS-8854
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8854-Consolidated-20150806.02.txt, HDFS-8854-HDFS-7285.00.patch,
HDFS-8854-HDFS-7285.01.patch, HDFS-8854-HDFS-7285.02.patch, HDFS-8854.00.patch

This message was sent by Atlassian JIRA

View raw message