hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8836) Skip newline on empty files with getMerge -nl
Date Mon, 31 Aug 2015 20:59:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724027#comment-14724027
] 

Hadoop QA commented on HDFS-8836:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  20m 30s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 2 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 54s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 17s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 25s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | site |   3m 18s | Site still builds. |
| {color:red}-1{color} | checkstyle |   1m  9s | The applied patch generated  3 new checkstyle
issues (total was 45, now 47). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   1m 52s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m  7s | Tests passed in hadoop-common. |
| | |  70m 45s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753354/HDFS-8836-03.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle site |
| git revision | trunk / caa04de |
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/12217/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HDFS-Build/12217/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/12217/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/12217/console |


This message was automatically generated.

> Skip newline on empty files with getMerge -nl
> ---------------------------------------------
>
>                 Key: HDFS-8836
>                 URL: https://issues.apache.org/jira/browse/HDFS-8836
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.6.0, 2.7.1
>            Reporter: Jan Filipiak
>            Assignee: kanaka kumar avvaru
>            Priority: Trivial
>         Attachments: HDFS-8836-01.patch, HDFS-8836-02.patch, HDFS-8836-03.patch
>
>
> Hello everyone,
> I recently was in the need of using the new line option -nl with getMerge because the
files I needed to merge simply didn't had one. I was merging all the files from one directory
and unfortunately this directory also included empty files, which effectively led to multiple
newlines append after some files. I needed to remove them manually afterwards.
> In this situation it is maybe good to have another argument that allows skipping empty
files.
> Thing one could try to implement this feature:
> The call for IOUtils.copyBytes(in, out, getConf(), false); doesn't
> return the number of bytes copied which would be convenient as one could
> skip append the new line when 0 bytes where copied or one would check the file size before.
> I posted this Idea on the mailing list http://mail-archives.apache.org/mod_mbox/hadoop-user/201507.mbox/%3C55B25140.3060005%40trivago.com%3E
but I didn't really get many responses, so I thought I my try this way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message