hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8622) Implement GETCONTENTSUMMARY operation for WebImageViewer
Date Fri, 07 Aug 2015 04:36:46 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661296#comment-14661296
] 

Akira AJISAKA commented on HDFS-8622:
-------------------------------------

Thanks [~jagadesh.kiran] for the update. Two comments:

1.
bq. Would you add a test case for a directory that has a symlink?
In other words,  would you add a test case to cover the following code?
{code:title=FSImageLoader#fillDirSummary}
      case SYMLINK:
        data[1]++;
        break;
      }
{code}
This test case is not for a symlink which links to a directory, but for a directory that has
a simlink to something. I'm thinking it's sufficient to create a symlink in {{dir1}}, which
links to a file (ex. {{file1}}).

2. 
{code:title=FSImageLoader#getContentSummaryMap}
    case SYMLINK:
      data[0] = 0;
      data[1] = 1;
      data[2] = 0;
      nsQuota = -1;
      data[3] = data[2] * f.getReplication();
      spaceQuota = -1;
      return fillSummaryMap(spaceQuota, nsQuota, data);
{code}
{{data\[2\] * f.getReplication()}} should be 0. I forgot to comment that.

> Implement GETCONTENTSUMMARY operation for WebImageViewer
> --------------------------------------------------------
>
>                 Key: HDFS-8622
>                 URL: https://issues.apache.org/jira/browse/HDFS-8622
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Jagadesh Kiran N
>            Assignee: Jagadesh Kiran N
>         Attachments: HDFS-8622-00.patch, HDFS-8622-01.patch, HDFS-8622-02.patch, HDFS-8622-03.patch,
HDFS-8622-04.patch, HDFS-8622-05.patch, HDFS-8622-06.patch, HDFS-8622-07.patch
>
>
>  it would be better for administrators if {code} GETCONTENTSUMMARY {code} are supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message