Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97C8B181B9 for ; Wed, 22 Jul 2015 15:19:10 +0000 (UTC) Received: (qmail 49642 invoked by uid 500); 22 Jul 2015 15:19:10 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 49595 invoked by uid 500); 22 Jul 2015 15:19:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 49579 invoked by uid 99); 22 Jul 2015 15:19:10 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 15:19:10 +0000 Date: Wed, 22 Jul 2015 15:19:10 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8795) Improve InvalidateBlocks#node2blocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637052#comment-14637052 ] Hudson commented on HDFS-8795: ------------------------------ SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #261 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/261/]) HDFS-8795. Improve InvalidateBlocks#node2blocks. (yliu) (yliu: rev 4025326288c0167ff300d4f7ecc96f84ed141912) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Improve InvalidateBlocks#node2blocks > ------------------------------------ > > Key: HDFS-8795 > URL: https://issues.apache.org/jira/browse/HDFS-8795 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: 2.8.0 > > Attachments: HDFS-8795.001.patch, HDFS-8795.002.patch > > > Currently we use {{TreeMap}} for {{node2blocks}}, actually there are only two place may need sorted: {{dump}}, {{getDatanodes}}. But {{getDatanodes}} is called by {{computeInvalidateWork}}, and we do a shuffle there, so the sort is unnecssary. For {{dump}}, certainly we need to make few modification. > So we can use {{HashMap}}. > From memory and performance view, {{HashMap}} is better than {{TreeMap}}, a simliar optimization HDFS-7433. -- This message was sent by Atlassian JIRA (v6.3.4#6332)