Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0635E174EC for ; Sat, 11 Jul 2015 15:42:08 +0000 (UTC) Received: (qmail 86866 invoked by uid 500); 11 Jul 2015 15:42:07 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 86816 invoked by uid 500); 11 Jul 2015 15:42:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86711 invoked by uid 99); 11 Jul 2015 15:42:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jul 2015 15:42:07 +0000 Date: Sat, 11 Jul 2015 15:42:07 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8751) Remove setBlocks API from INodeFile and misc code cleanup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623459#comment-14623459 ] Hudson commented on HDFS-8751: ------------------------------ SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2199 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2199/]) HDFS-8751. Remove setBlocks API from INodeFile and misc code cleanup. Contributed by Zhe Zhang (jing9: rev 47f4c54106ebb234a7d3dc71320aa584ecba161a) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java > Remove setBlocks API from INodeFile and misc code cleanup > --------------------------------------------------------- > > Key: HDFS-8751 > URL: https://issues.apache.org/jira/browse/HDFS-8751 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.7.0 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 2.8.0 > > Attachments: HDFS-8751.00.patch, HDFS-8751.01.patch > > > The public {{INodeFile#setBlocks}} API, when used outside {{INodeFile}}, is always called with {{null}}. Therefore we should replace it with a safer {{clearBlocks}} API. Also merging code cleanups from HDFS-7285 branch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)