Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 22 Jul 2015 09:23:04 +0000 (UTC)
From: "Akira AJISAKA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12843482.1436352277000.254354.1437556984835@Atlassian.JIRA>
In-Reply-To: <JIRA.12843482.1436352277000@Atlassian.JIRA>
References: <JIRA.12843482.1436352277000@Atlassian.JIRA>
 <JIRA.12843482.1436352277375@arcas>
Subject: [jira] [Commented] (HDFS-8735) Inotify : All events classes should
 implement toString() API.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HDFS-8735?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14636=
576#comment-14636576 ]=20

Akira AJISAKA commented on HDFS-8735:
-------------------------------------

Thanks [~cmccabe] for the comment.

bq. I would caution people not to start parsing the toString representation=
 since it might change over time (if we add new optional fields to the Even=
ts). But it is nice for debugging and logging.

Adding {{@Public}} and {{@Unstable}} to the subclasses is good for you? {{E=
vent}} class is annotated, but the subclasses are not annotated and that's =
why they don't exist in API doc.

> Inotify : All events classes should implement toString() API.
> -------------------------------------------------------------
>
>                 Key: HDFS-8735
>                 URL: https://issues.apache.org/jira/browse/HDFS-8735
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-8735.01.patch, HDFS-8735.patch
>
>
> Event classes is used by client, it=E2=80=99s good to implement toString(=
) API.
> {code}
> for(Event event : events){
> =09System.out.println(event.toString());
> }
> {code}
> This will give output like this
> {code}
> org.apache.hadoop.hdfs.inotify.Event$CreateEvent@6916d97d
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)