Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4048618A3E for ; Thu, 2 Jul 2015 18:09:05 +0000 (UTC) Received: (qmail 42568 invoked by uid 500); 2 Jul 2015 18:09:04 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 42494 invoked by uid 500); 2 Jul 2015 18:09:04 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 42427 invoked by uid 99); 2 Jul 2015 18:09:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2015 18:09:04 +0000 Date: Thu, 2 Jul 2015 18:09:04 +0000 (UTC) From: "Lei (Eddy) Xu (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-8712) Remove "public" and "abstract" modifiers in FsVolumeSpi and FsDatasetSpi MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lei (Eddy) Xu updated HDFS-8712: -------------------------------- Attachment: HDFS-8712.000.patch Remove {{public}} and {{abstract}} modifier in {{FsVolumeSpi}} and {{FsDatasetSpi}} interfaces. No test is included, since there is no actual code change. > Remove "public" and "abstract" modifiers in FsVolumeSpi and FsDatasetSpi > ------------------------------------------------------------------------ > > Key: HDFS-8712 > URL: https://issues.apache.org/jira/browse/HDFS-8712 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.7.0 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Priority: Trivial > Attachments: HDFS-8712.000.patch > > > In [Java Language Specification 9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]: > bq. It is permitted, but discouraged as a matter of style, to redundantly specify the public and/or abstract modifier for a method declared in an interface. > {{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many warnings in IDEs and {{checkstyle}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)