Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 1 Jul 2015 11:31:04 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12841964.1435750088000.69725.1435750264658@Atlassian.JIRA>
In-Reply-To: <JIRA.12841964.1435750088000@Atlassian.JIRA>
References: <JIRA.12841964.1435750088000@Atlassian.JIRA>
 <JIRA.12841964.1435750088267@arcas>
Subject: [jira] [Commented] (HDFS-8705) BlockStoragePolicySuite uses
 equalsIgnoreCase for name lookup, won't work in all locales
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-8705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609966#comment-14609966 ] 

Steve Loughran commented on HDFS-8705:
--------------------------------------

I should add that the locale most likely to break is turkey, where {{"I".toLowerCase()!="i"}}, so matches the policy {{"lazy_persist"}} wont match {{"LAZY_PERSIST"}}

> BlockStoragePolicySuite uses equalsIgnoreCase for name lookup, won't work in all locales
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8705
>                 URL: https://issues.apache.org/jira/browse/HDFS-8705
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> Looking at {{BlockStoragePolicySuite.getPolicy(name)}}, is using {{equalsIgnoreCase()}} to find a policy which matches a name.
> This will not work in all locales. It must use {{toLowerCase(Locale.ENGLISH).equals(name)}}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)