[ https://issues.apache.org/jira/browse/HDFS-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642478#comment-14642478
]
Hadoop QA commented on HDFS-8811:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 37s | Findbugs (version ) appears to be broken on
trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 3 new
or modified test files. |
| {color:green}+1{color} | javac | 7m 35s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 36s | The applied patch generated 6 new checkstyle
issues (total was 0, now 6). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs | 4m 20s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native | 3m 3s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 159m 31s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests | 0m 27s | Tests passed in hadoop-hdfs-client. |
| | | 204m 22s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestAppendSnapshotTruncate |
| | hadoop.hdfs.TestLeaseRecovery2 |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.server.namenode.ha.TestStandbyIsHot |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12747284/HDFS-8811-01.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1df7868 |
| checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/11843/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11843/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11843/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11843/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11843/console |
This message was automatically generated.
> Move BlockStoragePolicy name's constants from HdfsServerConstants.java to HdfsConstants.java
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-8811
> URL: https://issues.apache.org/jira/browse/HDFS-8811
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-8811-01.patch
>
>
> Currently {{HdfsServerConstants.java}} have following constants,
> {code} String HOT_STORAGE_POLICY_NAME = "HOT";
> String WARM_STORAGE_POLICY_NAME = "WARM";
> String COLD_STORAGE_POLICY_NAME = "COLD";{code}
> and {{HdfsConstants.java}} have the following
> {code} public static final String MEMORY_STORAGE_POLICY_NAME = "LAZY_PERSIST";
> public static final String ALLSSD_STORAGE_POLICY_NAME = "ALL_SSD";
> public static final String ONESSD_STORAGE_POLICY_NAME = "ONE_SSD";{code}
> It would be better to move all these to one place HdfsConstants.java, which client APIs
also could access since this presents in hdfs-client module.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|