hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8795) Improve InvalidateBlocks#node2blocks
Date Wed, 22 Jul 2015 14:27:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636998#comment-14636998
] 

Hudson commented on HDFS-8795:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #253 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/253/])
HDFS-8795. Improve InvalidateBlocks#node2blocks. (yliu) (yliu: rev 4025326288c0167ff300d4f7ecc96f84ed141912)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java


> Improve InvalidateBlocks#node2blocks
> ------------------------------------
>
>                 Key: HDFS-8795
>                 URL: https://issues.apache.org/jira/browse/HDFS-8795
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8795.001.patch, HDFS-8795.002.patch
>
>
> Currently we use {{TreeMap}} for {{node2blocks}}, actually there are only two place may
need sorted: {{dump}}, {{getDatanodes}}.  But {{getDatanodes}} is called by {{computeInvalidateWork}},
and we do a shuffle there, so the sort is unnecssary.  For {{dump}}, certainly we need to
make few modification.
> So we can use {{HashMap}}.
> From memory and performance view, {{HashMap}} is better than {{TreeMap}}, a simliar optimization
HDFS-7433. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message