hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-8795) Improve InvalidateBlocks#node2blocks
Date Wed, 22 Jul 2015 07:30:05 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Yi Liu updated HDFS-8795:
          Resolution: Fixed
        Hadoop Flags: Reviewed
    Target Version/s: 2.8.0  (was: 2.7.1)
              Status: Resolved  (was: Patch Available)

Thanks [~vinayrpet] for review.
The test failure is not related, committed to trunk and branch-2.

> Improve InvalidateBlocks#node2blocks
> ------------------------------------
>                 Key: HDFS-8795
>                 URL: https://issues.apache.org/jira/browse/HDFS-8795
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HDFS-8795.001.patch, HDFS-8795.002.patch
> Currently we use {{TreeMap}} for {{node2blocks}}, actually there are only two place may
need sorted: {{dump}}, {{getDatanodes}}.  But {{getDatanodes}} is called by {{computeInvalidateWork}},
and we do a shuffle there, so the sort is unnecssary.  For {{dump}}, certainly we need to
make few modification.
> So we can use {{HashMap}}.
> From memory and performance view, {{HashMap}} is better than {{TreeMap}}, a simliar optimization

This message was sent by Atlassian JIRA

View raw message