hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8750) FIleSystem does not honor Configuration.getClassLoader() while loading FileSystem implementations
Date Mon, 20 Jul 2015 10:25:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633385#comment-14633385
] 

Steve Loughran commented on HDFS-8750:
--------------------------------------

Don't worry about it: it's what the review process is for.

If there is one one lesson all of us working on Hadoop eventually learn, there are no "simple"
changes -a one-liner may not add a major new feature, but it is at much risk of breaking things
as the bigger patches. Hence the obsession with tests

> FIleSystem does not honor Configuration.getClassLoader() while loading FileSystem implementations
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8750
>                 URL: https://issues.apache.org/jira/browse/HDFS-8750
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fs, HDFS
>            Reporter: Himanshu
>            Assignee: Himanshu
>         Attachments: HDFS-8750.001.patch, HDFS-8750.002.patch
>
>
> In FileSystem.loadFileSystems(), at 
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2652
> a "scheme" -> "FileSystem implementation" map is created from the jars available on
classpath. It uses Thread.currentThread().getClassLoader() via ServiceLoader.load(FileSystem.class)
> Instead, loadFileSystems() should take Configuration as an argument and should first
check if a classloader is configured in configuration.getClassLoader(), if yes then ServiceLoader.load(FileSystem.class,
configuration.getClassLoader()) should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message