hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8735) Inotify : All events classes should implement toString() API.
Date Tue, 21 Jul 2015 06:18:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634578#comment-14634578
] 

Akira AJISAKA commented on HDFS-8735:
-------------------------------------

bq. {code}
+    @Override
+    public String toString() {
+      return new String("UnlinkEvent [path=" + path + ", timestamp=" + timestamp
+          + "]");
+    }
{code}
{{new String}} is redundant and should be removed. Sorry for the confusion.

> Inotify : All events classes should implement toString() API.
> -------------------------------------------------------------
>
>                 Key: HDFS-8735
>                 URL: https://issues.apache.org/jira/browse/HDFS-8735
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HDFS-8735.patch
>
>
> Event classes is used by client, it’s good to implement toString() API.
> {code}
> for(Event event : events){
> 	System.out.println(event.toString());
> }
> {code}
> This will give output like this
> {code}
> org.apache.hadoop.hdfs.inotify.Event$CreateEvent@6916d97d
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message