hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8717) OzoneHandler : Add common bucket objects
Date Wed, 15 Jul 2015 22:12:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628847#comment-14628847
] 

Arpit Agarwal commented on HDFS-8717:
-------------------------------------

A few more comments. Comments also posted at https://github.com/arp7/hadoop/commit/af27927fb3f777e25c9613b786a38955483b6837

# BucketInfo.java:208: Thanks for adding this comment. Should we add a Preconditions.checkState
to ensure that the volume is the same, so we catch any bugs wrt comparing across volumes?
# BucketInfo.java:223: Add similar assert here?
# ListBuckets.java:122: Nitpick: type bucketNaem
# ListBuckets.java:59: ListVolumes --> ListBuckets
# ListBuckets.java:77: If this a pure getter i.e. the caller is not expected to modify the
list of buckets then we should probably wrap {{buckets}} in Collections.unmodifiableList.


> OzoneHandler : Add common bucket objects
> ----------------------------------------
>
>                 Key: HDFS-8717
>                 URL: https://issues.apache.org/jira/browse/HDFS-8717
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>             Fix For: HDFS-7240
>
>         Attachments: hdfs-8717-HDFS-7240.001.patch, hdfs-8717-HDFS-7240.002.patch
>
>
> Add common bucket classes that are needed by the bucket REST interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message