hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8712) Remove "public" and "abstract" modifiers in FsVolumeSpi and FsDatasetSpi
Date Thu, 09 Jul 2015 10:45:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620314#comment-14620314
] 

Hudson commented on HDFS-8712:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/])
HDFS-8712. Remove 'public' and 'abstract' modifiers in FsVolumeSpi and FsDatasetSpi (Contributed
by Lei (Eddy) Xu) (vinayakumarb: rev bd4e10900cc53a2768c31cc29fdb3698684bc2a0)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java


> Remove "public" and "abstract" modifiers in FsVolumeSpi and FsDatasetSpi
> ------------------------------------------------------------------------
>
>                 Key: HDFS-8712
>                 URL: https://issues.apache.org/jira/browse/HDFS-8712
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Trivial
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8712.000.patch, HDFS-8712.001.patch
>
>
> In [Java Language Specification 9.4|http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4]:
> bq. It is permitted, but discouraged as a matter of style, to redundantly specify the
public and/or abstract modifier for a method declared in an interface.
> {{FsDatasetSpi}} and {{FsVolumeSpi}} mark methods as public, which cause many warnings
in IDEs and {{checkstyle}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message