hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kanaka kumar avvaru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8654) OzoneHandler : Add ACL support
Date Mon, 06 Jul 2015 12:48:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614985#comment-14614985
] 

kanaka kumar avvaru commented on HDFS-8654:
-------------------------------------------

Thanks for the patch [~anu], 

Small nits:
1) {{OzoneACLTypes}} can be renamed to {{OzoneACLType}}

2) OzoneAcl#parseAcl
{code}OzoneACLTypes aclType;
    aclType = OzoneACLTypes.getACLType(parts[0].toLowerCase());
{code}  
can be replaced with {code}OzoneACLTypes aclType = OzoneACLTypes.getACLType(parts[0].toLowerCase());
{code} 
to wrap in single line. 
3) Similarly declaration & assignment can be made as single line for {{OzoneACLRights
rights;}} 
4) {code} if (((aclType == OzoneACLTypes.USER) || (aclType == OzoneACLTypes.GROUP)) &&
        (parts[1].length() == 0)) { {code}
{{&&}} may need to be in next line to satisfy checkstyle (or) for better readability



> OzoneHandler : Add ACL support
> ------------------------------
>
>                 Key: HDFS-8654
>                 URL: https://issues.apache.org/jira/browse/HDFS-8654
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: hdfs-8654-HDFS-7240.001.patch, hdfs-8654-HDFS-7240.002.patch
>
>
> Add ACL support which is needed by Ozone Buckets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message