hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8563) Erasure Coding: fsck handles file smaller than a full stripe
Date Wed, 08 Jul 2015 01:11:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617787#comment-14617787
] 

Jing Zhao commented on HDFS-8563:
---------------------------------

The patch looks good to me. Just some minor comments:
# Looks like we do not need to use the replication factor to check if the file is an EC file,
since HdfsFileStatus includes information about ECSchema.
{code}
+      if (file.getReplication() == 0) {
+        assert storedBlock instanceof BlockInfoStriped;
+        targetFileReplication = ((BlockInfoStriped) storedBlock)
+            .getRealTotalBlockNum();
{code}
# There is an unused import in NameNodeFsck.java.

> Erasure Coding: fsck handles file smaller than a full stripe
> ------------------------------------------------------------
>
>                 Key: HDFS-8563
>                 URL: https://issues.apache.org/jira/browse/HDFS-8563
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8563-HDFS-7285.01.patch
>
>
> Uploaded a small file. Fsck shows it's UNRECOVERABLE. It's not correct.
> {noformat}
> Erasure Coded Block Groups:
>  Total size:    1366 B
>  Total files:   1
>  Total block groups (validated):        1 (avg. block group size 1366 B)
>   ********************************
>   UNRECOVERABLE BLOCK GROUPS:   1 (100.0 %)
>   MIN REQUIRED EC BLOCK:        6
>   ********************************
>  Minimally erasure-coded block groups:  0 (0.0 %)
>  Over-erasure-coded block groups:       0 (0.0 %)
>  Under-erasure-coded block groups:      1 (100.0 %)
>  Unsatisfactory placement block groups:         0 (0.0 %)
>  Default schema:        RS-6-3
>  Average block group size:      4.0
>  Missing block groups:          0
>  Corrupt block groups:          0
>  Missing ec-blocks:             5 (55.555557 %)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message