hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8495) Consolidate append() related implementation into a single class
Date Mon, 06 Jul 2015 22:07:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615750#comment-14615750
] 

Haohui Mai commented on HDFS-8495:
----------------------------------

The patch looks good. Some nits:

{code}
if (fsn.isPermissionEnabled()) {
    fsd.checkPathAccess(pc, iip, FsAction.WRITE);
}
{code}

Should be {{fsd.isPermissionEnabled()}}.

Around line 117 of the patch.

{code}
fsn.getBlockManager()
{code}

Should be {{fsd.getBlockManager()}}. And it makes senses to extract it as a local variable.

+1 once addressed.

> Consolidate append() related implementation into a single class
> ---------------------------------------------------------------
>
>                 Key: HDFS-8495
>                 URL: https://issues.apache.org/jira/browse/HDFS-8495
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8495-000.patch, HDFS-8495-001.patch, HDFS-8495-002.patch, HDFS-8495-003.patch,
HDFS-8495-003.patch, HDFS-8495-004.patch, HDFS-8495-005.patch
>
>
> This jira proposes to consolidate {{FSNamesystem#append()}} related methods into a single
class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message