hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8202) Improve end to end stirpping file test to add erasure recovering test
Date Wed, 22 Jul 2015 05:48:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636340#comment-14636340
] 

Zhe Zhang commented on HDFS-8202:
---------------------------------

Thanks for the work Xinwei!

The patch looks good overall. A few comments:
# Can we write a loop instead of manually add all possibilities for {{testReadWithDNFailure}}
and {{testReadCorruptedData}}?
# {{testReadWithBlockCorrupted}} could use a simple Javadoc
# Similar comments apply to {{TestWriteStripedFileWithFailure}} tests. 
# We can also eliminate the {{srcPath}} parameter of {{writeFileWithDNFailure}} if the same
value is always used.

> Improve end to end stirpping file test to add erasure recovering test
> ---------------------------------------------------------------------
>
>                 Key: HDFS-8202
>                 URL: https://issues.apache.org/jira/browse/HDFS-8202
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Xinwei Qin 
>         Attachments: HDFS-8202-HDFS-7285.003.patch, HDFS-8202.001.patch, HDFS-8202.002.patch
>
>
> This to follow on HDFS-8201 to add erasure recovering test in the end to end stripping
file test:
> * After writing certain blocks to the test file, delete some block file;
> * Read the file content and compare, see if any recovering issue, or verify the erasure
recovering works or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message