hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8058) Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile
Date Tue, 14 Jul 2015 18:24:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626810#comment-14626810
] 

Jing Zhao commented on HDFS-8058:
---------------------------------

The 007 patch looks good to me. Just two minors:
# In {{INodeFileAttributes}}, it's better to keep the {{isStriped}} attribute of the snapshot
copy the same with the INodeFile. Thus maybe we can add a boolean parameter to {{INodeFileAttributes.SnapshotCopy}}'s
constructor, and in {{FSImageFormatPBSnapshot#loadFileDiffList}} we pass in {{file.isStriped}}.
{code}
-      header = HeaderFormat.toLong(preferredBlockSize, replication,
+      header = HeaderFormat.toLong(preferredBlockSize, replication, false,
           storagePolicyID);
{code}
# Looks like we do not need to add a new constructor for INodeFile.

> Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-8058
>                 URL: https://issues.apache.org/jira/browse/HDFS-8058
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Yi Liu
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8058-HDFS-7285.003.patch, HDFS-8058-HDFS-7285.004.patch, HDFS-8058-HDFS-7285.005.patch,
HDFS-8058-HDFS-7285.006.patch, HDFS-8058-HDFS-7285.007.patch, HDFS-8058.001.patch, HDFS-8058.002.patch
>
>
> This JIRA is to use {{BlockInfo[] blocks}} for both striped and contiguous blocks in
INodeFile.
> Currently {{FileWithStripedBlocksFeature}} keeps separate list for striped blocks, and
the methods there duplicate with those in INodeFile, and current code need to judge {{isStriped}}
then do different things. Also if file is striped, the {{blocks}} in INodeFile occupy a reference
memory space.
> These are not necessary, and we can use the same {{blocks}} to make code more clear.
> I keep {{FileWithStripedBlocksFeature}} as empty for follow use: I will file a new JIRA
to move {{dataBlockNum}} and {{parityBlockNum}} from *BlockInfoStriped* to INodeFile, since
ideally they are the same for all striped blocks in a file, and store them in block will waste
NN memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message