hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8058) Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile
Date Fri, 10 Jul 2015 06:26:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621816#comment-14621816

Zhe Zhang commented on HDFS-8058:

Thanks Jing for the helpful review!

Those unnecessary changes were in the patch because I took the trunk version of {{INodeFile}}
and picked striping-specific logics from the branch patch. I just filed HDFS-8751 to merge
those code cleanups to trunk, as well as to replace {{setBlocks}} with {{clearBlocks}}.

bq. The whole FileWithStripedBlocksFeature can be deleted
I agree. It's a good idea to reuse a bit from {{REPLICATION}}. In the future when we separate
BM and NN we can consider creating a slimmer {{BlockInfo}} for NN, and store some common properties
on file level, like {{cellSize}} and {{ecSchema}}. We can revisit adding back that class at
that time. I will make this change and simplify the corresponding edit log and fsimage codes.

> Erasure coding: use BlockInfo[] for both striped and contiguous blocks in INodeFile
> -----------------------------------------------------------------------------------
>                 Key: HDFS-8058
>                 URL: https://issues.apache.org/jira/browse/HDFS-8058
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Yi Liu
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8058-HDFS-7285.003.patch, HDFS-8058-HDFS-7285.004.patch, HDFS-8058.001.patch,
> This JIRA is to use {{BlockInfo[] blocks}} for both striped and contiguous blocks in
> Currently {{FileWithStripedBlocksFeature}} keeps separate list for striped blocks, and
the methods there duplicate with those in INodeFile, and current code need to judge {{isStriped}}
then do different things. Also if file is striped, the {{blocks}} in INodeFile occupy a reference
memory space.
> These are not necessary, and we can use the same {{blocks}} to make code more clear.
> I keep {{FileWithStripedBlocksFeature}} as empty for follow use: I will file a new JIRA
to move {{dataBlockNum}} and {{parityBlockNum}} from *BlockInfoStriped* to INodeFile, since
ideally they are the same for all striped blocks in a file, and store them in block will waste
NN memory.

This message was sent by Atlassian JIRA

View raw message