Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EBD31774D for ; Sat, 27 Jun 2015 15:40:07 +0000 (UTC) Received: (qmail 44480 invoked by uid 500); 27 Jun 2015 15:40:07 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 44431 invoked by uid 500); 27 Jun 2015 15:40:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 44415 invoked by uid 99); 27 Jun 2015 15:40:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Jun 2015 15:40:07 +0000 Date: Sat, 27 Jun 2015 15:40:07 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8656) Preserve compatibility of ClientProtocol#rollingUpgrade after finalization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604202#comment-14604202 ] Hudson commented on HDFS-8656: ------------------------------ SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2187 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2187/]) HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang: rev 60b858bfa65e0feb665e1a84784a3d45e9091c66) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java > Preserve compatibility of ClientProtocol#rollingUpgrade after finalization > -------------------------------------------------------------------------- > > Key: HDFS-8656 > URL: https://issues.apache.org/jira/browse/HDFS-8656 > Project: Hadoop HDFS > Issue Type: Bug > Components: rolling upgrades > Affects Versions: 2.8.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Priority: Critical > Fix For: 2.8.0 > > Attachments: hdfs-8656.001.patch, hdfs-8656.002.patch, hdfs-8656.003.patch, hdfs-8656.004.patch > > > HDFS-7645 changed rollingUpgradeInfo to still return an RUInfo after finalization, so the DNs can differentiate between rollback and a finalization. However, this breaks compatibility for the user facing APIs, which always expect a null after finalization. Let's fix this and edify it in unit tests. > As an additional improvement, isFinalized and isStarted are part of the Java API, but not in the JMX output of RollingUpgradeInfo. It'd be nice to expose these booleans so JMX users don't need to do the != 0 check that possibly exposes our implementation details. -- This message was sent by Atlassian JIRA (v6.3.4#6332)