Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E374C18898 for ; Tue, 16 Jun 2015 15:34:06 +0000 (UTC) Received: (qmail 86506 invoked by uid 500); 16 Jun 2015 15:34:06 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 86460 invoked by uid 500); 16 Jun 2015 15:34:06 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86448 invoked by uid 99); 16 Jun 2015 15:34:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2015 15:34:06 +0000 Date: Tue, 16 Jun 2015 15:34:06 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8607) TestFileCorruption doesn't work as expected MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588227#comment-14588227 ] Hudson commented on HDFS-8607: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk #2176 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2176/]) HDFS-8607. TestFileCorruption doesn't work as expected. (Contributed by Walter Su) (arp: rev 32ffda1266c11dd98ce7f439a89fce206adf751a) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > TestFileCorruption doesn't work as expected > ------------------------------------------- > > Key: HDFS-8607 > URL: https://issues.apache.org/jira/browse/HDFS-8607 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 2.7.0 > Reporter: Walter Su > Assignee: Walter Su > Fix For: 2.8.0 > > Attachments: HDFS-8607.01.patch > > > Although it passes, it's useless. > {code} > 77 File[] blocks = data_dir.listFiles(); > 78 assertTrue("Blocks do not exist in data-dir", (blocks != null) && (blocks.length > 0)); > 79 for (int idx = 0; idx < blocks.length; idx++) { > 80 if (!blocks[idx].getName().startsWith(Block.BLOCK_FILE_PREFIX)) { > 81 continue; > 82 } > 83 System.out.println("Deliberately removing file "+blocks[idx].getName()); > 84 assertTrue("Cannot remove file.", blocks[idx].delete()); > 85 } > {code} > blocks are located at finalized/subdir0/subdir0, but line 77 only returns "subdir0" because {{File.listFiles()}} is not recursive. So line 83~84 will never be excuted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)