Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC85B17AC0 for ; Sat, 13 Jun 2015 17:31:01 +0000 (UTC) Received: (qmail 24572 invoked by uid 500); 13 Jun 2015 17:31:01 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24520 invoked by uid 500); 13 Jun 2015 17:31:01 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24509 invoked by uid 99); 13 Jun 2015 17:31:01 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Jun 2015 17:31:01 +0000 Date: Sat, 13 Jun 2015 17:31:01 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8593) Calculation of effective layout version mishandles comparison to current layout version in storage. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584728#comment-14584728 ] Chris Nauroth commented on HDFS-8593: ------------------------------------- The checkstyle warning is not actionable. > Calculation of effective layout version mishandles comparison to current layout version in storage. > --------------------------------------------------------------------------------------------------- > > Key: HDFS-8593 > URL: https://issues.apache.org/jira/browse/HDFS-8593 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-8593.001.patch > > > HDFS-8432 introduced the concept of a minimum compatible layout version so that downgrade is applicable in a wider set of circumstances. This includes logic for determining if the current layout version in storage is within the bounds of the minimum compatible layout version. There is an inverted comparison in this logic, which can result in an incorrect calculation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)