Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 15 Jun 2015 04:14:00 +0000 (UTC)
From: "Vinayakumar B (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12837114.1434023026000.69048.1434341640497@Atlassian.JIRA>
In-Reply-To: <JIRA.12837114.1434023026000@Atlassian.JIRA>
References: <JIRA.12837114.1434023026000@Atlassian.JIRA>
 <JIRA.12837114.1434023026759@arcas>
Subject: [jira] [Commented] (HDFS-8580) Erasure coding: Persist cellSize in
 BlockInfoStriped and StripedBlocksFeature
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585409#comment-14585409 ] 

Vinayakumar B commented on HDFS-8580:
-------------------------------------

I think you forgot to add {{builder.setCellSize(cellSize);}} in {{FSImageFormatPBINode.Saver.save(OutputStream out, INodeFile n)}}

> Erasure coding: Persist cellSize in BlockInfoStriped and StripedBlocksFeature
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-8580
>                 URL: https://issues.apache.org/jira/browse/HDFS-8580
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8580-HDFS-7285.01.patch, HDFS-8580.00.patch
>
>
> Zhe Zhang, Kai Zheng and I had a offline discussion. Here is what we thought:  Add a cellSize field in BlockInfoStriped as a workaround, and deal with memory usage in follow-on.(HDFS-8059)
> discussion in HDFS-8494:
> from Walter Su:
> {quote}
> I think BlockInfoStriped needs to keep cellSize.
> {quote}
> from [~vinayrpet]:
> {quote}
> I too was thinking the same when the FSImageLoader problem has came up. This will increase the memory usage by ~4bytes for each block though.
> {quote}
> from [~jingzhao]
> {quote}
> -Also, we should consider adding a chunk size field to StripedBlockProto and removing the cell size field from HdfsFileStatus. In this way we can access the chunk size information in the storage layer.-
> {quote}
> ==
> update:
> from [~jingzhao]
> {quote}
> For fsimage part, since HDFS-8585 just removes StripedBlockProto, I guess what we can do here is to either 1) add the cellSize information into StripedBlocksFeature in fsimage.proto, or 2) bring StripedBlockProto back and put block info and cell size there.
> {quote}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)