Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 6 Jun 2015 01:20:00 +0000 (UTC)
From: "Tsz Wo Nicholas Sze (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12835824.1433538307000.8127.1433553600773@Atlassian.JIRA>
In-Reply-To: <JIRA.12835824.1433538307000@Atlassian.JIRA>
References: <JIRA.12835824.1433538307000@Atlassian.JIRA>
 <JIRA.12835824.1433538307235@arcas>
Subject: [jira] [Commented] (HDFS-8546) Use try with resources in
 DataStorage and Storage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575485#comment-14575485 ] 

Tsz Wo Nicholas Sze commented on HDFS-8546:
-------------------------------------------

- There is still a double try-statements in isPreUpgradableLayout.  Note that FileLock is AutoCloseable
- We should add a message including when creating OverlappingFileLockException.

> Use try with resources in DataStorage and Storage
> -------------------------------------------------
>
>                 Key: HDFS-8546
>                 URL: https://issues.apache.org/jira/browse/HDFS-8546
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Minor
>         Attachments: HDFS-8546.001.patch, HDFS-8546.002.patch, HDFS-8546.003.patch
>
>
> We have some old-style try/finally to close files in DataStorage and Storage, let's update them.
> Also a few small cleanups:
> * Actually check that tryLock returns a FileLock in isPreUpgradableLayout
> * Remove unused parameter from writeProperties
> * Add braces for one-line if statements per coding style


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)