Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C672617C27 for ; Fri, 26 Jun 2015 14:35:07 +0000 (UTC) Received: (qmail 77890 invoked by uid 500); 26 Jun 2015 14:35:07 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 77842 invoked by uid 500); 26 Jun 2015 14:35:07 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 77701 invoked by uid 99); 26 Jun 2015 14:35:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2015 14:35:06 +0000 Date: Fri, 26 Jun 2015 14:35:06 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8546) Use try with resources in DataStorage and Storage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602952#comment-14602952 ] Hudson commented on HDFS-8546: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/]) HDFS-8546. Use try with resources in DataStorage and Storage. (wang: rev 1403b84b122fb76ef2b085a728b5402c32499c1f) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java > Use try with resources in DataStorage and Storage > ------------------------------------------------- > > Key: HDFS-8546 > URL: https://issues.apache.org/jira/browse/HDFS-8546 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 2.7.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8546.001.patch, HDFS-8546.002.patch, HDFS-8546.003.patch, HDFS-8546.004.patch, HDFS-8546.005.patch, HDFS-8546.006.patch > > > We have some old-style try/finally to close files in DataStorage and Storage, let's update them. > Also a few small cleanups: > * Actually check that tryLock returns a FileLock in isPreUpgradableLayout > * Remove unused parameter from writeProperties > * Add braces for one-line if statements per coding style -- This message was sent by Atlassian JIRA (v6.3.4#6332)