Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 538971877D for ; Tue, 16 Jun 2015 15:17:03 +0000 (UTC) Received: (qmail 7399 invoked by uid 500); 16 Jun 2015 15:17:03 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 7346 invoked by uid 500); 16 Jun 2015 15:17:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 7333 invoked by uid 99); 16 Jun 2015 15:17:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2015 15:17:03 +0000 Date: Tue, 16 Jun 2015 15:17:02 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8540) Mover should exit with NO_MOVE_BLOCK if no block can be moved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588182#comment-14588182 ] Hudson commented on HDFS-8540: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #228 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/228/]) HDFS-8540. Mover should exit with NO_MOVE_BLOCK if no block can be moved. Contributed by surendra singh lilhore (szetszwo: rev 321940cf19375febe9660e96d905360cfcc15f5f) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestStorageMover.java * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java Move HDFS-8540 to 2.8 in CHANGES.txt. (szetszwo: rev 1b6695a4c0d76fe18d6524cc1379bc1185708c6f) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > Mover should exit with NO_MOVE_BLOCK if no block can be moved > ------------------------------------------------------------- > > Key: HDFS-8540 > URL: https://issues.apache.org/jira/browse/HDFS-8540 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Reporter: Tsz Wo Nicholas Sze > Assignee: surendra singh lilhore > Fix For: 2.8.0 > > Attachments: HDFS-8540.patch, HDFS-8540_1.patch, HDFS-8540_2.patch, HDFS-8540_3.patch > > > When there are files not satisfying their storage policy and no move is possible, Mover exits with SUCCESS. It should exit with NO_MOVE_BLOCK. > The bug seems in the following code. When StorageTypeDiff is not empty and scheduleMoves4Block return false, it does not update hasRemaining. Also, there is no indication of "No block can be moved" for the entire iteration. > {code} > //Mover.processFile(..) > if (!diff.removeOverlap(true)) { > if (scheduleMoves4Block(diff, lb, ecSchema)) { > hasRemaining |= (diff.existing.size() > 1 && > diff.expected.size() > 1); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)