Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A806817DBC for ; Wed, 3 Jun 2015 00:44:30 +0000 (UTC) Received: (qmail 19056 invoked by uid 500); 2 Jun 2015 21:57:50 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 19001 invoked by uid 500); 2 Jun 2015 21:57:50 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 18988 invoked by uid 99); 2 Jun 2015 21:57:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 21:57:50 +0000 Date: Tue, 2 Jun 2015 21:57:50 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-8517) Fix a decoding issue in stripped block recovering in client side MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-8517: ---------------------------- Attachment: HDFS-8517-HDFS-7285.v2.patch Since the remaining issues are mostly minor, I just made these changes and upload a v2 patch here. The patch also does some refactoring in the test code and fixes {{TestDFSStripedInputStream#testPreadWithDNFailure}}. Please let me know if it looks ok to you, [~drankye] and [~zhz]. > Fix a decoding issue in stripped block recovering in client side > ---------------------------------------------------------------- > > Key: HDFS-8517 > URL: https://issues.apache.org/jira/browse/HDFS-8517 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HDFS-8517-HDFS-7285-v1.patch, HDFS-8517-HDFS-7285.v2.patch > > > [~jingzhao] reported a decoding issue in HDFS-8481 in the comment copied below: > bq. While debugging HDFS-8319, I just found that in TestWriteReadStripedFile#testWritePreadWithDNFailure, if we change the startOffsetInFile from cellSize * 5 to 0, the test fails with the following error msg: > {noformat} > java.lang.AssertionError: Byte at 524288 should be the same expected:<27> but was:<-9> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at org.junit.Assert.assertEquals(Assert.java:555) > at org.apache.hadoop.hdfs.TestWriteReadStripedFile.testWritePreadWithDNFailure(TestWriteReadStripedFile.java:390) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)