hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8687) Remove the duplicate usage message from Dfsck.java
Date Mon, 29 Jun 2015 17:45:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605970#comment-14605970
] 

Arpit Agarwal commented on HDFS-8687:
-------------------------------------

Hi [~brahmareddy], thanks for submitting this fix.

We should remove the line {{ToolRunner.printGenericCommandUsage(System.err);}} instead. Looks
like removing printUsage will only print the generic options.

> Remove the duplicate usage message from Dfsck.java
> --------------------------------------------------
>
>                 Key: HDFS-8687
>                 URL: https://issues.apache.org/jira/browse/HDFS-8687
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-8687.patch
>
>
> Toolrunner also give same usage message,, I think , we can remove
> {{printUsage(System.err);}}
> {code}
> if ((args.length == 0) || ("-files".equals(args[0]))) {
>       printUsage(System.err);
>       ToolRunner.printGenericCommandUsage(System.err);
>     } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message