hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8656) Preserve compatibility of ClientProtocol#rollingUpgrade after finalization
Date Sat, 27 Jun 2015 15:19:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604193#comment-14604193
] 

Hudson commented on HDFS-8656:
------------------------------

SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #239 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/239/])
HDFS-8656. Preserve compatibility of ClientProtocol#rollingUpgrade after finalization. (wang:
rev 60b858bfa65e0feb665e1a84784a3d45e9091c66)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeMXBean.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeMXBean.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java


> Preserve compatibility of ClientProtocol#rollingUpgrade after finalization
> --------------------------------------------------------------------------
>
>                 Key: HDFS-8656
>                 URL: https://issues.apache.org/jira/browse/HDFS-8656
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rolling upgrades
>    Affects Versions: 2.8.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>            Priority: Critical
>             Fix For: 2.8.0
>
>         Attachments: hdfs-8656.001.patch, hdfs-8656.002.patch, hdfs-8656.003.patch, hdfs-8656.004.patch
>
>
> HDFS-7645 changed rollingUpgradeInfo to still return an RUInfo after finalization, so
the DNs can differentiate between rollback and a finalization. However, this breaks compatibility
for the user facing APIs, which always expect a null after finalization. Let's fix this and
edify it in unit tests.
> As an additional improvement, isFinalized and isStarted are part of the Java API, but
not in the JMX output of RollingUpgradeInfo. It'd be nice to expose these booleans so JMX
users don't need to do the != 0 check that possibly exposes our implementation details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message