hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8644) OzoneHandler : Add volume handler
Date Thu, 25 Jun 2015 18:33:05 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601686#comment-14601686
] 

Arpit Agarwal commented on HDFS-8644:
-------------------------------------

Hi [~anu], the patch looks great. Minor feedback below.

# {{UserHandlerBuilder#getAuthHandler}} instantiates {{Simple}} auth handler by default. I
saw you added the config key {{DFS_OZONE_USER_AUTH_PROVIDER}} which is unused. Did you mean
to use it instead of hard-coding {{Simple}}?
# Missing @Override annotations on {{VolumeProcessTemplate#doProcess}} implementations in
{{VolumeHandler}}.
# {{OzoneUtils#getRequestID}} - can we make request IDs UUIDs?
# Nitpick: StorageHandlerBuilder:31 - {{new ThreadLocal<StorageHandler>}} --> {{new
ThreadLocal<>}}
# {{verifyBucketName}} - Do you think some of this logic would be easier to express as regular
expressions? I am okay either way.

I forgot to note in earlier Ozone reviews that we need interface audience and stability annotations
on public classes. We can file a separate Jira for it.

> OzoneHandler : Add volume handler
> ---------------------------------
>
>                 Key: HDFS-8644
>                 URL: https://issues.apache.org/jira/browse/HDFS-8644
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: hdfs-8644-HDFS-7240.001.patch, hdfs-8644-HDFS-7240.002.patch
>
>
> Add volume handler logic that dispatches volume related calls to the right interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message