hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kanaka kumar avvaru (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8614) OzoneHandler : Add Quota Support
Date Wed, 17 Jun 2015 06:14:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589358#comment-14589358
] 

kanaka kumar avvaru commented on HDFS-8614:
-------------------------------------------

Hi [~anu], thanks for the patch. Few comments :

1. OzoneQuota:{{sizeInBytes()}} can be called multiple times. Can we avoid the convertion
to bytes through a seperate local variable?
2. OzoneQuota:In my Opinion {{-1}} itself is sufficient to treat it as quota is not set or
undefined case. And by default we can treat it as {{ bytes}} if unit is not explicitly provided
which is more comfortable for users
3. Header: Can we add the constants as required by the feature JIRA, so that the usage and
definition is clear to review. If you agree pls remove the constants not used in this patch.


> OzoneHandler : Add Quota Support 
> ---------------------------------
>
>                 Key: HDFS-8614
>                 URL: https://issues.apache.org/jira/browse/HDFS-8614
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: HDFS
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: hdfs-8614-hdfs-7240.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message